infra: fix build and plugin execution #434
Conversation
|
https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/690/workflows/5c9a0e73-fd6f-4fa8-9a60-8384b0cbfdcf/jobs/664?invite=true#step-103-245 |
|
Found some docker image maintenance at https://hub.docker.com/repository/docker/checkstyle/sonarqube-maven-git |
|
https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/693/workflows/60b90dc0-263b-4a11-8013-459a9e470d60/jobs/667?invite=true#step-103-382
|
|
prerequisite: we will need to update the used image to use SQ 9+ as this is the current version necessary by the plugin. i did not find such image on dockerhub, though. |
rnveach
force-pushed
the
circleci
branch
4 times, most recently
from
affae91 to
40c8893
Compare
nrmancuso
force-pushed
the
circleci
branch
17 times, most recently
from
1fc3e51 to
6bed351
Compare
|
Build and execution of sonar takes less than 2 minutes, I do not see necessity of cache usage. |
| - persist_to_workspace: | ||
| root: /home/circleci | ||
| paths: | ||
| - project |
There was a problem hiding this comment.
We do not need composed images, since we can build jar and generate class files in previous step, and persist the project directory for sonar execution job.
| - run: | ||
| name: Install packages | ||
| command: apk add maven |
There was a problem hiding this comment.
Installation of maven takes less than 5 seconds, I do not think we need custom sonar image with maven pre-installed
|
Kudos, SonarCloud Quality Gate passed!
|
nrmancuso
changed the title
This circleci run actually runs our plugin with sonar, so this is one way to test. If we could find a way, we could configure this for integration tests. |
|
@nrmancuso Thank you so much for this. |
Identified at #433 (comment)